-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simple AEB #33535
base: master
Are you sure you want to change the base?
Simple AEB #33535
Conversation
|
Probably not. At least some different active state. For AEB you need to a) go active spontaneously when the user hasn't explicitly engaged, and b) continue actuating with driver braking (preexisting or rising edge) or even opposing driver gas (probably preexisting only). These are all completely antithetical to the existing safety model and would make conventional ACC safety hopelessly untestable spaghetti. |
f9a46d5
to
5eb9f1f
Compare
5eb9f1f
to
a7bfe9e
Compare
This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity. |
This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes. |
This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity. |
This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes. |
open questions
CC.longActive = True
for AEB?